Skip to content

Make std::panic!() identical to core::panic!() on Rust 2021 #80879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Make std::panic!() identical to core::panic!() on Rust 2021 #80879

wants to merge 9 commits into from

Conversation

@m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Jan 10, 2021

This makes std::panic!(..) identical to core::panic!(..) on edition 2012, by re-exporting core::panic::panic_2021 from std::panic.

This is blocked on #80846.

This change includes #80851 for now. I'll rebase this once that one is merged.

r? @ghost

@m-ou-se m-ou-se mentioned this pull request Jan 10, 2021
Closed
16 tasks
@m-ou-se m-ou-se changed the title Std use core panic Make std::panic!() identical to core::panic!() on Rust 2021 Jan 10, 2021
@m-ou-se m-ou-se added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 10, 2021
@m-ou-se m-ou-se force-pushed the std-use-core-panic branch from 2381c88 to 2f4d89e Compare January 10, 2021 14:55
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@m-ou-se m-ou-se force-pushed the std-use-core-panic branch from 2f4d89e to c5273bd Compare January 12, 2021 17:38
@bors
Copy link
Collaborator

bors commented Jan 14, 2021

☔ The latest upstream changes (presumably #79328) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkov
Copy link
Contributor

r? @petrochenkov

@petrochenkov
Copy link
Contributor

Blocked on #80851.

@petrochenkov petrochenkov added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 23, 2021
@m-ou-se
Copy link
Member Author

m-ou-se commented Jan 24, 2021

This is now included in #80851. Closing this.

@m-ou-se m-ou-se closed this Jan 24, 2021
@m-ou-se m-ou-se deleted the std-use-core-panic branch January 24, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkov petrochenkov

Labels

S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@m-ou-se @rust-log-analyzer @bors @petrochenkov